quote filename shelling out to grep #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +35,7 @@ var printIssue = function(fileName, lineNum, matchedString){ | |||
|
|
|||
| var findFixmes = function(file){ | |||
| // Prepare the grep string for execution (uses BusyBox grep) | |||
| var grepString = "grep -inHwoE " + fixmeStrings + " " + file; | |||
| var grepString = "grep -inHwoE " + fixmeStrings + " \"" + file + "\""; | |||
There was a problem hiding this comment.
Nice! I like your fix. I don't think it's better, but one other idea I had was something like:
var grepString = ["grep -inHwoE", fixmeStrings, "'" + file + "'"].join(" ");
There was a problem hiding this comment.
@ABaldwinHunter You're right, we're joining enough bits now that it's not very readable. Will change in a sec.
If a path has a space in it, the grep will fail unless we quote the filename.
wfleming
force-pushed
the
will/quote-file
branch
from
053a2e5 to
04423c4
Compare
|
@codeclimate/review recently noticed I let this PR lie fallow. I think it's still a bug, and have updated my patch. Review please? |
|
LGTM |
wfleming
added a commit
that referenced
this pull request
Nov 19, 2015
quote filename shelling out to grep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a path has a space in it, the grep will fail unless we quote the filename.